Uploaded image for project: 'Code Tools'
  1. Code Tools
  2. CODETOOLS-7901600

jcheck should test for UseNewCode* flags in the code

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: New
    • Priority: P3
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: tools
    • Labels:
      None

      Description

      This is inspired by JDK-8149356, that handles the accidental commit of UseNewCode in the codebase. This flag is a development-time flag, and should not be used in committed code. Therefore, it might make sense to amend jcheck to test for these flags in the source code changes.

      It can go like this: no new lines in the changeset can have UseNewCode in it, except for the actual UseNewCode declaration (e.g. if globals.hpp gets modified/reshuffled).

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                shade Aleksey Shipilev
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: