Uploaded image for project: 'Code Tools'
  1. Code Tools
  2. CODETOOLS-7902067

CachingTestFilter caches based on the content of a test description, not the location

    Details

    • Type: Bug
    • Status: Open
    • Priority: P2
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: tools
    • Labels:
      None

      Description

      This has arisen out of CODETOOLS-7902065. This is the root problem for that issue, whereas the issue itself describes a suggested solution.

      CachingTestFilter uses a HashTable<TestDescription,Boolean> to cache the results of a filter. This caches based on the *content* of the test description, and not the location of the test within the test suite. While this is OK for most filters, it means that filters based on the location of the test (specifically, ExcludeListFilter) will not be cached correctly.

      Although it will not cache as effectively, it would be better to cache results based on the location of the test, i.e. its rootRelativeURL, or use an IdentityHashMap.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jjg Jonathan Gibbons
                Reporter:
                jjg Jonathan Gibbons
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated: