Uploaded image for project: 'Code Tools'
  1. Code Tools
  2. CODETOOLS-7902935

Look into explicit @run statements for assumed run actions

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: New
    • Priority: P4
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: tools
    • Labels:
      None

      Description

      I am trying to solve JDK-8267241 by providing a single TestNG-driven test a separate configuration. Unfortunately, it does not seem to be possible, since the whole test group is driven by TestNG:

      ./test/jdk/java/time/test/TEST.properties:
      TestNG.dirs = ..

      ...so adding @run statement to the test in that group:

      diff --git a/test/jdk/java/time/test/java/time/format/TestZoneTextPrinterParser.java b/test/jdk/java/time/test/java/time/format/TestZoneTextPrinterParser.java
      index 77ccf37ad56..d84bdb919c7 100644
      --- a/test/jdk/java/time/test/java/time/format/TestZoneTextPrinterParser.java
      +++ b/test/jdk/java/time/test/java/time/format/TestZoneTextPrinterParser.java
      @@ -51,6 +51,7 @@ import org.testng.annotations.Test;
        * @test
        * @bug 8081022 8151876 8166875 8189784 8206980
        * @key randomness
      + * @run testng -Xmx2g TestZoneTextPrinterParser
        */
       
      ...does not really work. JTReg seems to treat that test as ASSUMED_ACTION TestNG:

      #-----testdescription-----
      $file=/home/shade/trunks/jdk/test/jdk/java/time/test/java/time/format/TestZoneTextPrinterParser.java
      $root=/home/shade/trunks/jdk/test/jdk
      keywords=testng
      library=/test/lib /test/jdk/tools/lib
      modules=java.base/java.time\:open
      packageRoot=java/time/
      run=ASSUMED_ACTION testng test.java.time.format.TestZoneTextPrinterParser\n
      source=TestZoneTextPrinterParser.java
      testngClass=test.java.time.format.TestZoneTextPrinterParser
      title=\

      I wonder if JTReg can look into explicit @run declarations even when assumed actions are there. Otherwise, in cases like these, we would need to drop "TestNG.dirs" from the global config and add explicit @run testng to every other test, which would be tedious.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              shade Aleksey Shipilev
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated: