Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-4081691

garbage collection can invalidate objects in 2 methods in ObjectStreamClass.c

    XMLWordPrintable

    Details

    • Subcomponent:
    • Resolved In Build:
      1.1.5
    • CPU:
      generic
    • OS:
      solaris_2.5.1
    • Verification:
      Verified

      Description

      (JDK 114) in function
      java_io_ObjectStreamClass_getFieldSignatures() in file
      src/share/java/lang/ObjectStreamClass.c.
      (The same bug exists in function
      java_io_ObjectStreamClass_getMethodSignatures()).

      Here is the code that is buggy:

          for (i = cbFieldsCount(cb) - 1; i >= 0; i--) {
      ...
              namearray = (HString **)unhand(namearrayhandle)->body;
              namearray[i] = makeJavaString(buffer, strlen(buffer));
      ...
           }

      Suppose garbage collection occurs during the call to makeJavaString().
      Couldn't the garbage collection cause the object that namearray points
      at to be moved, hence invalidating namearray's value ?

      Should the code be fixed by doing something like:

          /* loop thru each field in the class */
          for (i = cbFieldsCount(cb) - 1; i >= 0; i--) {
      ...
              strobj = makeJavaString(p, strlen(p));
              namearray = (HString **)unhand(namearrayhandle)->body;
              namearray[i] = strobj;
      ...
           }

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jfialli Joe Fialli
              Reporter:
              jbenoit Jonathan Benoit (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Imported:
                Indexed: