Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-4112819

(gc) Adjustment to setting value "min_request" within file gc.c, build JAE 1.2

    XMLWordPrintable

    Details

    • Subcomponent:
    • CPU:
      generic
    • OS:
      solaris_2.5.1

      Description

      Adjustment to setting of value "min_request" within file gc.c.
      This bug occurs in gc.c only when the USE_MALLOC compile time option is used.

      In the following patch listing, "L" refers to the left path which is original
      file from JavaSoft and "R" refers to the right path which is our modified file.

      Comparison of J:\JAE1_2T\src\share\javavm\runtime\GC.C and
      J:\PC\SHARE\javavm\runtime\GC.C
      Version 1.206

      ----------------------------------------------------- BUG FIX
      L4864 min_request = max_request;

      R4876 min_request = max_request - /* srb */
      R4877 _barriersize_red - _barriersize_orange;

      The next two lines of gc.c file say:
      min_request += _barriersize_red + _barriersize_orange;
      if (min_request > max_request) {
      /*...complain that not enough memory */

      Now obviously if min_request is equal to max_reqest, then adding in the
      barriersizes will always make it larger than max_request. So
      min_request has to be at least the two barriersizes smaller than
      max_request.

        Attachments

          Activity

            People

            Assignee:
            hongzh Hong Zhang
            Reporter:
            jbenoit Jonathan Benoit (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Imported:
              Indexed: