Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-4317988

CompoundBorder.isBorderOpaque() wrong implementation!

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.4.0
    • Component/s: client-libs
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      beta
    • CPU:
      generic
    • OS:
      generic

      Description



      Name: skT88420 Date: 03/01/2000


      Here I send you the patch I had to make to the isBorderOpaque(),
      I left your implementation under comment!

      You can see, that using your implementation the compound border
      returns false if the outsideBorder is null, without asking the
      insideBorder!

          /**
           * Returns whether or not this compound border is opaque.
           * Returns true if both the inside and outside borders are
           * non-null and opaque; returns false otherwise.
           */
          public boolean isBorderOpaque() {
      // Patch:
      return (outsideBorder == null || outsideBorder.isBorderOpaque()) &&
                     (insideBorder == null || insideBorder.isBorderOpaque());
      // End Patch
      // return (outsideBorder != null && outsideBorder.isBorderOpaque()) &&
      // (insideBorder != null && insideBorder.isBorderOpaque());
          }

      Thanks
        Patrick
      (Review ID: 95682)
      ======================================================================

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                amfowler Anne Fowler (Inactive)
                Reporter:
                skonchad Sandeep Konchady
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Imported:
                  Indexed: