Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-4344895

SPARC only: Stack overflow from bad interaction of osr and deoptimization

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.4.0_02
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      02
    • CPU:
      generic
    • OS:
      solaris_8

      Backports

        Description

        SPARC only

        Following test causes a stack overflow error when run with C2 and
        DeoptimizeALot.

        public class Adapters5 {
          int longJohn() {
            return hashCode();
          }
          public static void main(String args[]) {
            Adapters5 adapt = new Adapters5();
            int i000=0,i001=0,i002=0,i003=0,i004=0,i005=0,i006=0,i007=0,i008=0,i009=0;
            int i010=0,i011=0,i012=0,i013=0,i014=0,i015=0,i016=0,i017=0,i018=0,i019=0;
            int i020=0,i021=0,i022=0,i023=0,i024=0,i025=0,i026=0,i027=0,i028=0,i029=0;
            int i030=0,i031=0,i032=0,i033=0,i034=0,i035=0,i036=0,i037=0,i038=0,i039=0;
            int i040=0,i041=0,i042=0,i043=0,i044=0,i045=0,i046=0,i047=0,i048=0,i049=0;
            int i050=0,i051=0,i052=0,i053=0,i054=0,i055=0,i056=0,i057=0,i058=0,i059=0;
            int i060=0,i061=0,i062=0,i063=0,i064=0,i065=0,i066=0,i067=0,i068=0,i069=0;
            int i070=0,i071=0,i072=0,i073=0,i074=0,i075=0,i076=0,i077=0,i078=0,i079=0;
            int i080=0,i081=0,i082=0,i083=0,i084=0,i085=0,i086=0,i087=0,i088=0,i089=0;
            int i090=0,i091=0,i092=0,i093=0,i094=0,i095=0,i096=0,i097=0,i098=0,i099=0;
            long i = 0;
            while(true) {
              adapt.longJohn();
              if (++i % 100000 == 0) {
        System.out.println("Iteration: " + i);
              }
            }
          }
        }

        >java_g -server -Xbatch -XX:-Inline -XX:+DeoptimizeALot -XX:CompileOnly=Adapters5.main -Xss128k Adapters5
        VM option '+UseC2CallingConventions'
        VM option '-Inline'
        VM option '+DeoptimizeALot'
        VM option 'CompileOnly=Adapters5.main'
        Iteration: 100000
        Iteration: 200000
        Iteration: 300000
        Iteration: 400000
        Iteration: 500000
        Iteration: 600000
        Iteration: 700000
        Iteration: 800000
        Iteration: 900000
        Iteration: 1000000
        Iteration: 1100000
        Iteration: 1200000
        Exception in thread "main" java.lang.StackOverflowError
                at Adapters5.longJohn(Adapters5.java:3)
                at Adapters5.main(Adapters5.java:19)


        The problem is with an interaction between OSR and deoptimization.
        When main() is OSR'ed, the caller's interpreted frame has main()'s
        non-parameter locals allocated within it (normal interpreted to
        interpreted calling convention). The problem is that deoptimization
        does not expect this, and reallocates main()'s non-parameter locals
        in it's caller's frame, growing the stack at each deoptimization.

        Deoptimization allocates the non-parameter locals because they are not
        allocated when a I2C adapter exists (instead of an OSR adapter), and
        therefore need to be allocated when an I2C adapter is replaced with
        an interpreted frame.


            Case 1 deopt. an OSR frame (bug) Case 2 deopt. a i2c frame (okay)

              OSR after deopt I2C after deopt
         | | | | | | | |
         |--------------| |--------------| |--------------| |--------------|
         | | | | | | | |
         | main interp. | | main interp. | | main interp. | | main interp. |
         | | | | | | | |
         |- - - - - - - | |- - - - - - - | |--------------| |- - - - - - - |
         |nonparm localsl |nonparm localsl | | |nonparm locals|
         |--------------| |- - - - - - - | | i2c | |--------------|
         | | |nonparm locals| | | | |
         | osr | |--------------| |--------------| | longJohn |
         | | | | | | | interp. |
         |--------------| | longJohn | | longJohn | | |
         | | | interp. | | compiled | |--------------|
         | longJohn | | | | | | |
         | compiled | |--------------| |--------------| | |
         | | | | | | | |
         |--------------|
         | |

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                mpalecznsunw Michael Paleczny (Inactive)
                Reporter:
                rknippelsunw Ross Knippel (Inactive)
                Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:
                  Imported:
                  Indexed: