Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-5007074

thread_id's should be cleaned up

    XMLWordPrintable

    Details

    • Subcomponent:
    • CPU:
      generic
    • OS:
      generic

      Description

      wrt bug 5006514, Coleen Phillimore points out that

      ----

      "I don't understand why current_thread_id() is called at all, when the thread_id is stored in osthread as thread_id() and I believe most calls should refer to that one instead. I think os::current_thread_id() is more expensive, osthread()->thread_id() is cheaper.

      "The type of osthread _thread_id varys by platform:

        thread_t _thread_id; // Solaris thread id

      "but there are also lots of these in the code:

        print %d osthread()->thread_id().

      ----

      We ought to regularize the type of thread_id's, perhaps by defining a platform-
      specific scalar type that we use everywhere. intx is not specific enough.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            phh Paul Hohensee
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Imported:
              Indexed: