Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-6531149

Use right LP64 definition for 64 bit conditional build of hotspot

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 7
    • Fix Version/s: hs10
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
    • Resolved In Build:
      b10
    • CPU:
      generic
    • OS:
      solaris

      Backports

        Description

        In $(hotspot_ws)/build/solaris/makefiles/rules.make, it have different build rules for 64 bit and 32 bit. Currently, it explicitly tests whether LP64 equals to 1 or not. This works only when one set LP64=1 as the build option (or ARCH_DATA_MODEL=64). If one set LP64=true or something else, it won't work. The right way of testing whether it is performing 64 bit build or 32 bit is to test whether LP64 exists or not. So we need to change:
        ifeq ($(LP64), 1) to
        ifdef LP64

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  xlu Xiaobin Lu (Inactive)
                  Reporter:
                  xlu Xiaobin Lu (Inactive)
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Imported:
                    Indexed: