Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-6566786

RE's script that checks copyright/license text does not catch copyright errors in some cases

    Details

    • Subcomponent:
    • Resolved In Build:
      b144
    • CPU:
      sparc
    • OS:
      solaris_8
    • Verification:
      Verified

      Description

      Filing this bug per Dave's request (please assign the bug to Dave Katleman).

      Script: /java/re/jdk/7/nightly/bin/share/check.sh
      (the script checks that every source file has an OSS copyright notice)

      1) Known limitation of the script: it does not verify copyright year range.
      It would be nice if this was fixed (this is probably more an RFE, then a bug).

      2) While testing the script, we found cases when script passes an incorrect copyright string:

      For example, in the following file:
        /net/jano/export/disk29/jcg/ws/7/awt/Bad_copyright_IdentityLinkedList.java
      the copyright line has "(c)" string in it, however the script reports no errors.
        " * Copyright (c) 2007 Sun Microsystems, Inc. All Rights Reserved."

      To repro the issue:
      [jcg-integrator@karachi:share]$ pwd
      /java/re/jdk/7/nightly/bin/share
      [jcg-integrator@karachi:share]$ sh check.sh jdk /net/jano/export/disk29/jcg/ws/7/awt/Bad_copyright_IdentityLinkedList.java

      Fri May 25 18:38:00 PDT 2007
      mkdir: "../logs": Read-only file system
      WARNING: Couldn't write to default logs dir, sending to /var/tmp/logs
          LOG file: /var/tmp/logs/copyright_log.txt.28790
          ERR file: /var/tmp/logs/copyright_err.txt.28790
       Done. 0 error(s).
       Fri May 25 19:04:48 PDT 2007

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                katleman David Katleman (Inactive)
                Reporter:
                lana Svetlana Steuck (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Imported:
                  Indexed: