Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-6657688

undefine DEBUG, factor out 'main' unit test code in jbroker files {security,maps,securemove}.cpp

    Details

    • Subcomponent:
    • Introduced In Build:
      b12
    • Introduced In Version:
    • Resolved In Build:
      b13
    • CPU:
      generic
    • OS:
      windows, windows_vista
    • Verification:
      Verified

      Description

      Per-file and per-directory security checking added to Java Kernel jbroker program for Java Kernel installs on Windows Vista includes error reporting conditionally compiled with preprocessor label DEBUG. DEBUG is currently defined in the three security modules (security.cpp,maps.cpp,securemove.cpp). With an error detected in file and directory move operations requested by the jbroker.cpp code a messagebox will currently pop up with specific error information. This temporary, specific information is intended for Java Kernel engineering. This is needed for testing of build 12 to insure no scenarios bring about unexpected error handling indicating a defect.

      But this debug code must be disabled after build 12 testing to ensure any file/dir move failures will be reported by jbroker back to DownloadManager in the usual manner without any new user-visible behavior.

      In addition, each of the modules above has a "main method" conditionally compiled on a second variable. These main methods should be simplified so unit testing details are wholely contained in the test scripts (testsecurity, testmaps, testsecuremove). This is important to prevent environment or example.map detail changes from forcing changes to the .cpp files to keep the unit tests running.

      Testing w/o DEBUG defined during compilation was done prior to the b12 putback of CR 6638662. This CR can be tested with binaries from a deployment nightly build well ahead of the b13 integration.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                psoper Pete Soper (Inactive)
                Reporter:
                psoper Pete Soper (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Imported:
                  Indexed: