Details
-
Type:
Bug
-
Status: Resolved
-
Priority:
P5
-
Resolution: Fixed
-
Affects Version/s: 7
-
Fix Version/s: 9
-
Component/s: client-libs
-
Labels:
-
Subcomponent:
-
Resolved In Build:b30
-
CPU:generic
-
OS:generic
Backports
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8084986 | emb-9 | Yuri Nesterenko | P5 | Resolved | Fixed | team |
Description
From a 2d-dev list posting :
I notice that there is a native method freeTransform() in LCMS.java, but
LCMS.c doesn't have an implementation for that. There is only
LCMS_freeTransform(), which of course isn't a JNI method. It could
easily be implemented like this:
JNIEXPORT void JNICALL
Java_sun_java2d_cmm_lcms_LCMS_freeTransform(JNIEnv* env, jclass cls,
jlong id) {
LCMS_freeTransform(env, id);
}
Wondering, why this never showed up anywhere, I digged a little deeper
an looked around for possible callers of freeTransform(), but found
none. Considering this, I think this must be a stale method maybe left
from some earlier experiments and could be removed now. Is this correct?
In this case, I would propose to remove the native method declaration.
I notice that there is a native method freeTransform() in LCMS.java, but
LCMS.c doesn't have an implementation for that. There is only
LCMS_freeTransform(), which of course isn't a JNI method. It could
easily be implemented like this:
JNIEXPORT void JNICALL
Java_sun_java2d_cmm_lcms_LCMS_freeTransform(JNIEnv* env, jclass cls,
jlong id) {
LCMS_freeTransform(env, id);
}
Wondering, why this never showed up anywhere, I digged a little deeper
an looked around for possible callers of freeTransform(), but found
none. Considering this, I think this must be a stale method maybe left
from some earlier experiments and could be removed now. Is this correct?
In this case, I would propose to remove the native method declaration.
Attachments
Issue Links
- backported by
-
JDK-8084986 Redundant unused native method declaration in LCMS.java
-
- Resolved
-