Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-6817950

refactor ClassReader to improve attribute handling

    Details

    • Type: Enhancement
    • Status: Closed
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 7
    • Fix Version/s: 7
    • Component/s: tools
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b55
    • CPU:
      generic
    • OS:
      generic
    • Verification:
      Not verified

      Description

      Currently, ClassReader uses somewhat clunky code to read attributes that is inflexible (if-then-else chain) and somewhat less than correct (for example, classfile version is not taken into account when determining if an attribute is valid or not.)

      It would be better to refactor the code as a collection of attribute readers. This will make the code more robust for updates (e.g. 308, jigsaw) and downstream products (e.g. NetBeans) that need to define additional classfile attributes.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jjg Jonathan Gibbons
                Reporter:
                jjg Jonathan Gibbons
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Imported:
                  Indexed: