Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-6899049

G1: Clean up code in ptrQueue.[ch]pp and ptrQueue.inline.hpp

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P5
    • Resolution: Fixed
    • Affects Version/s: 7
    • Fix Version/s: 9
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
      gc
    • Resolved In Build:
      b94
    • CPU:
      generic
    • OS:
      generic

      Description

      During the code reviews for 6895788 a comment was made about the cleanliness of the current code in ptrQueue.hpp, ptrQueue.cpp, and ptrQueue.hpp.

      There are:
        * duplicated service routines (defined in the PtrQueue class and static within the .cpp file).

        * unused routines.

        * Loops that have strides other than 1 (which can be rewritten).

      We also allocate an additional data structure that has one entry for each completed buffer (CompletedBufferNode) that is unnecessary. The completed buffers could be chained in some other way.

      It would be desirable to clean up this code.

        Attachments

          Activity

            People

            • Assignee:
              kbarrett Kim Barrett
              Reporter:
              johnc John Cuthbertson
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Imported:
                Indexed: