Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-6953952

collectedHeap.cpp should use #ifdef _LP64 not LP64

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: hs19
    • Fix Version/s: hs19
    • Component/s: hotspot
    • Subcomponent:
      gc
    • Introduced In Build:
      b09
    • Introduced In Version:
    • Resolved In Build:
      b02
    • CPU:
      generic
    • OS:
      generic

      Backports

        Description

        From email thread on openjdk:-

        Vladimir Kozlov wrote:
        > The file also have LP64 instead of _LP64:
        >
        > src/share/vm/gc_interface/collectedHeap.cpp:#ifdef LP64
        >

        Yes, that one is probably not fatal (as far as i can see because
        i think LP64 gets defined when building 64-bit and this has been around
        a lot longer than COMPLER2; i'll check), but we should fix that too...

        thanks Vladimir.
        -- ramki


        > Vladimir
        >
        > Y. Srinivas Ramakrishna wrote:
        >> 6953483 Typo related to ReduceInitialCardMarks
        >>
        >> Workaround for the case of CMS: -XX:-ReduceInitialCardMarks.
        >>
        >> No issue for other collectors (G1, which may otherwise have been
        >> vulnerable, has this optimization switched off).
        >>
        >> Thanks, ChenGuang, for bringing this to our attention.
        >> -- ramki
        >>
        >> Y. Srinivas Ramakrishna wrote:
        >>> Looks like I am responsible for that typo (which is still there).
        >>> I'll test and fix that issue. Thanks for the fix!
        >>>
        >>> -- ramki
        >>>
        >>> ChenGuang Sun wrote:
        >>>> Hi,
        >>>>
        >>>> I'm reading the code and have noticed a minor typo in the function
        >>>> "CollectedHeap::pre_initialize()".
        >>>>
        >>>> I think it should be "#ifdef COMPILER2" instead of "#ifdef
        >>>> COMPLER2". I haven't checked whether it has been corrected in the
        >>>> latest revision.
        >>>>
        >>>> Thanks,
        >>>> Chen

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                ysr Y. Ramakrishna
                Reporter:
                ysr Y. Ramakrishna
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:
                  Imported:
                  Indexed: