Details

    • Type: Bug
    • Status: Closed
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 7
    • Fix Version/s: 8
    • Component/s: security-libs
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b38
    • CPU:
      generic
    • OS:
      generic
    • Verification:
      Not verified

      Backports

        Description

        Do you really need the double synchronization here (that is, the two
        synchronizedMap()s and the synchronized block in the constructor)? The
        only place you're using it is exclusively in the constructor or it's
        callers, so just the one lock should be sufficient. I think you can
        remove the SynchronizedMap. -- Bradford Wetmore

          Activity

          Hide
          xuelei Xue-Lei Fan added a comment -
          BT2:EVALUATION

          remove the unnecessary synchronization.
          Show
          xuelei Xue-Lei Fan added a comment - BT2:EVALUATION remove the unnecessary synchronization.
          Hide
          xuelei Xue-Lei Fan added a comment -
          BT2:PUBLIC COMMENTS

          webrev: http://cr.openjdk.java.net/~xuelei/6996372/webrev.01/
          changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f0842ed897c3

          Trival update, hard to test, no new regression test.
          Show
          xuelei Xue-Lei Fan added a comment - BT2:PUBLIC COMMENTS webrev: http://cr.openjdk.java.net/~xuelei/6996372/webrev.01/ changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f0842ed897c3 Trival update, hard to test, no new regression test.

            People

            • Assignee:
              xuelei Xue-Lei Fan
              Reporter:
              xuelei Xue-Lei Fan
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Imported:
                Indexed: