Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-7019199

download link should be moved out of translatable resource files

    Details

    • Subcomponent:
    • CPU:
      x86
    • OS:
      windows

      Description

      b130 PIT

      This CR is based on my review on webrev, not snap shot or any testing on the binary.

      In the .rc files for installer on windows, the download and download help links are not "translated" in non-English locales.

      IDD_ERROR_HELP_DIALOG in jinstallcom_xx.rc
      The text of download link is http://java.com/en/download/help, but it should be http://java.com/xx/download/help, where xx is the locale code.
      The link can be tried in the browser to see it's there.

      Same problem also happens in resource_xx.rc

      IDS_ERROR_MESSAGEURL "http://java.com/en/download/help/index.xml"

      There may be more. We may need to update the checking script to check that there is no "English" download page in non-English resource files.

        Attachments

          Activity

            People

            • Assignee:
              jqzuo Jennifer Zuo (Inactive)
              Reporter:
              yhuang Yong Huang (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Imported:
                Indexed: