Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-7043064

sun/java2d/cmm/ tests failed against RI b141 & b138-nightly

    Details

    • Subcomponent:
      2d
    • Introduced In Build:
      b141
    • Introduced In Version:
      7
    • Resolved In Build:
      b108
    • CPU:
      generic
    • OS:
      generic

      Description

      See comments

        Issue Links

          Activity

          Hide
          prr Philip Race added a comment -
          BT2:EVALUATION

          > java.awt.color.CMMException: Can not write tag data.
          > at sun.java2d.cmm.lcms.LCMS.setTagData(Native Method)
          > at java.awt.color.ICC_Profile.setData(ICC_Profile.java:1400)

          This is the same problem as the TCK failures reported in
          7042594: 3 testis api/java_awt/Color/ICC_ProfileRGB/index.html
          Show
          prr Philip Race added a comment - BT2:EVALUATION > java.awt.color.CMMException: Can not write tag data. > at sun.java2d.cmm.lcms.LCMS.setTagData(Native Method) > at java.awt.color.ICC_Profile.setData(ICC_Profile.java:1400) This is the same problem as the TCK failures reported in 7042594: 3 testis api/java_awt/Color/ICC_ProfileRGB/index.html
          Hide
          bae Andrew Brygin added a comment -
          BT2:EVALUATION

          sun/java2d/cmm/ColorConvertOp/ColConvDCMTest.java

          This test compares a conversion results with golden images,
          that does not work in case of openjdk, due to different set
          of color profiles.

          sun/java2d/cmm/ColorConvertOp/MTSafetyTest.java

          this test likely fails due to an attempt to use PYCC profile
          in image conversion. Existing PYCC profile in openjdk is incorrect
          and need to be replaced.
           
          sun/java2d/cmm/ProfileOp/ReadWriteProfileTest.java

          This test tries to set an byte array filled with zero as a tag content,
          and it makes this test incorrect.
          Show
          bae Andrew Brygin added a comment - BT2:EVALUATION sun/java2d/cmm/ColorConvertOp/ColConvDCMTest.java This test compares a conversion results with golden images, that does not work in case of openjdk, due to different set of color profiles. sun/java2d/cmm/ColorConvertOp/MTSafetyTest.java this test likely fails due to an attempt to use PYCC profile in image conversion. Existing PYCC profile in openjdk is incorrect and need to be replaced.   sun/java2d/cmm/ProfileOp/ReadWriteProfileTest.java This test tries to set an byte array filled with zero as a tag content, and it makes this test incorrect.
          Hide
          bae Andrew Brygin added a comment -
          Test failures, mentioned here were resolved as a part of the fix for 8016150.

          The only exception is ReadWriteProfileTest. This test relies on an assumption,
          that we read a data for a tag in the exactly same form as it was written.
          However, this assumption is not correct in case of lcms, because this
          library may perform some sort of modifications on the tag data.
          For example, plain text tags can be promoted to multilinguage tags,
          color points can be normalized and etc. To get this test working, we ether
          have to upgrade the tag comparison routines in the test, or force
          "as is" tag injection in lcms. The second option seems to be a bit dangerous
          to me because it potentially open doors for an injection of malformed tags
          into a profile.

           
          Show
          bae Andrew Brygin added a comment - Test failures, mentioned here were resolved as a part of the fix for 8016150. The only exception is ReadWriteProfileTest. This test relies on an assumption, that we read a data for a tag in the exactly same form as it was written. However, this assumption is not correct in case of lcms, because this library may perform some sort of modifications on the tag data. For example, plain text tags can be promoted to multilinguage tags, color points can be normalized and etc. To get this test working, we ether have to upgrade the tag comparison routines in the test, or force "as is" tag injection in lcms. The second option seems to be a bit dangerous to me because it potentially open doors for an injection of malformed tags into a profile.  
          Hide
          bae Andrew Brygin added a comment -
          ReadWriteProfile test need to be upgraded to correctly compare tag data.
          Show
          bae Andrew Brygin added a comment - ReadWriteProfile test need to be upgraded to correctly compare tag data.
          Hide
          hgupdate HG Updates added a comment -
          URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a07c907a82b5
          User: bae
          Date: 2013-09-04 08:17:00 +0000
          Show
          hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a07c907a82b5 User: bae Date: 2013-09-04 08:17:00 +0000
          Hide
          hgupdate HG Updates added a comment -
          URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/a07c907a82b5
          User: lana
          Date: 2013-09-18 00:31:25 +0000
          Show
          hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/a07c907a82b5 User: lana Date: 2013-09-18 00:31:25 +0000

            People

            • Assignee:
              bae Andrew Brygin
              Reporter:
              vpotokov Valerii Potokov (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Imported:
                Indexed: