Details

    • Type: Enhancement
    • Status: Open
    • Priority: P2
    • Resolution: Unresolved
    • Affects Version/s: 7
    • Fix Version/s: 10
    • Component/s: infrastructure
    • Subcomponent:
    • CPU:
      sparc
    • OS:
      generic

      Description

      Provide legal notice comment check, to ensure that JDK legal notice are correct prior to integration

        Activity

        Hide
        vasya Vassili Igouchkine (Inactive) added a comment - - edited
        I am working on Legal notice check and fix project for quite some time.
        I have code doing this check and fix, however we do not decided yet
        where to place it- to jcheck or some other place and so I am not sure if we
        fix this problem the way it is originally reported in this bug (add to jcheck).
        Show
        vasya Vassili Igouchkine (Inactive) added a comment - - edited I am working on Legal notice check and fix project for quite some time. I have code doing this check and fix, however we do not decided yet where to place it- to jcheck or some other place and so I am not sure if we fix this problem the way it is originally reported in this bug (add to jcheck).
        Hide
        katleman David Katleman added a comment -
        Yes, the check could be placed somewhere other than jcheck.

        jcheck was recommended because the optimal place to fix incorrect legal notices is before a changeset is checked in, just like it's done for other source file formatting checks.

        http://openjdk.java.net/projects/code-tools/jcheck
            Changeset comments and source files do not contain tabs, carriage returns, or trailing spaces.

        It's undesirable to perform the check post commit since a separate bug to fix the legal notice error would be needed.
        Pre commit check outside of jcheck is fine, as long as it's always performed automatically.
        Any non jcheck solution should to be accessible outside of Oracle, as commits happen there as well.
        Show
        katleman David Katleman added a comment - Yes, the check could be placed somewhere other than jcheck. jcheck was recommended because the optimal place to fix incorrect legal notices is before a changeset is checked in, just like it's done for other source file formatting checks. http://openjdk.java.net/projects/code-tools/jcheck     Changeset comments and source files do not contain tabs, carriage returns, or trailing spaces. It's undesirable to perform the check post commit since a separate bug to fix the legal notice error would be needed. Pre commit check outside of jcheck is fine, as long as it's always performed automatically. Any non jcheck solution should to be accessible outside of Oracle, as commits happen there as well.

          People

          • Assignee:
            Unassigned
            Reporter:
            katleman David Katleman
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Imported:
              Indexed: