Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-7172640

C2: instrinsic implementations in LibraryCallKit should use argument() instead of pop()

    XMLWordPrintable

    Details

    • Subcomponent:
    • Resolved In Build:
      b12
    • CPU:
      generic
    • OS:
      generic

      Backports

        Description

        Most intrinsics in LibraryCallKit re-push the arguments that have been popped off before the call to just pop them again as arguments. It would be much cleaner and more correct to use argument() accessors instead.

        Another problem is that it is very tricky to find the places where the stack pointer needs to be adjusted to the correct value for re-execution (uncommon traps). This adjustment is a plain SP bump and decrease after the call. In itself very error prone and it could be handled in a much more elegant way.

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                twisti Christian Thalinger
                Reporter:
                twisti Christian Thalinger
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:
                  Imported:
                  Indexed: