Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: hs25
    • Fix Version/s: hs25
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
    • Introduced In Build:
      b31
    • Introduced In Version:
      8
    • Resolved In Build:
      b35
    • CPU:
      generic
    • OS:
      generic

      Backports

        Description

        While working on a fix for 8014431, it was found that the fix for 8007037 in constantPool.cpp needs to be revised. Please refer to comment in 8007037 for details.

          Issue Links

            Activity

            Hide
            dcubed Daniel Daugherty added a comment -
            Moving to hotspot/jvmti to match the cat/subcat of 8007037.
            Show
            dcubed Daniel Daugherty added a comment - Moving to hotspot/jvmti to match the cat/subcat of 8007037.
            Hide
            dholmes David Holmes added a comment -
            For convenience:

            This fix is broken:

            bool match = compare_entry_to(k1, cp2, k2, CHECK_false) && compare_operand_to(i1, cp2, i2, CHECK_false);

            You can not use CHECK_ macros on functions that are then subject to boolean comparison. The above will expand to:

            bool match = compare_entry_to(k1, cp2, k2, THREAD);
            if (HAS_PENDING_EXCEPTION) return false;
            (0) && compare_operand_to(i1, cp2, i2, THREAD);
            if (HAS_PENDING_EXCEPTION) return false;
            (0);

            So match has the wrong value.

            See discussion from:

            http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2013-May/007332.html
            Show
            dholmes David Holmes added a comment - For convenience: This fix is broken: bool match = compare_entry_to(k1, cp2, k2, CHECK_false) && compare_operand_to(i1, cp2, i2, CHECK_false); You can not use CHECK_ macros on functions that are then subject to boolean comparison. The above will expand to: bool match = compare_entry_to(k1, cp2, k2, THREAD); if (HAS_PENDING_EXCEPTION) return false; (0) && compare_operand_to(i1, cp2, i2, THREAD); if (HAS_PENDING_EXCEPTION) return false; (0); So match has the wrong value. See discussion from: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2013-May/007332.html
            Hide
            hgupdate HG Updates added a comment -
            URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/51af5fae397d
            User: zgu
            Date: 2013-05-28 18:30:17 +0000
            Show
            hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/51af5fae397d User: zgu Date: 2013-05-28 18:30:17 +0000
            Hide
            hgupdate HG Updates added a comment -
            URL: http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/51af5fae397d
            User: amurillo
            Date: 2013-05-31 21:23:25 +0000
            Show
            hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/hsx/hsx25/hotspot/rev/51af5fae397d User: amurillo Date: 2013-05-31 21:23:25 +0000

              People

              • Assignee:
                ccheung Calvin Cheung
                Reporter:
                ccheung Calvin Cheung
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: