Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8016302

Change type of the number of GC workers to unsigned int (2)

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: hs25
    • Fix Version/s: 8u20
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
      gc
    • Resolved In Build:
      b10

      Backports

        Description

        In 7121618 variables representing GC workers (worker id, worker id offset) have been changed from int to unsigned int.

        Since then, code reintroduced the use of int's for this type of variable; fix this by aligning the code to use uints for ints.

        The following egrep command line may be useful to find these occurrences (these may however not be all of them):

        egrep -m1 "\Wint worker" `find . -name '*.?pp'`

        shows that a least the following files (all G1) seem to be affected:

        gc_implementation/g1/concurrentG1Refine.hpp
        gc_implementation/g1/g1RemSet.hpp
        gc_implementation/g1/g1GCPhaseTimes.cpp
        gc_implementation/g1/g1HotCardCache.hpp
        gc_implementation/g1/concurrentMark.cpp
        gc_implementation/g1/dirtyCardQueue.hpp
        gc_implementation/g1/dirtyCardQueue.cpp
        gc_implementation/g1/g1GCPhaseTimes.hpp
        gc_implementation/g1/concurrentG1RefineThread.cpp
        gc_implementation/g1/g1CollectedHeap.hpp
        gc_implementation/g1/concurrentG1Refine.cpp
        gc_implementation/g1/g1CollectedHeap.cpp
        gc_implementation/g1/g1RemSet.cpp
        gc_implementation/g1/concurrentG1RefineThread.hpp
        gc_implementation/g1/g1HotCardCache.cpp
        gc_implementation/g1/g1OopClosures.hpp
        gc_implementation/g1/satbQueue.hpp
        gc_implementation/g1/satbQueue.cpp

          Activity

          Hide
          tschatzl Thomas Schatzl added a comment -
          Due to wrong fix version, a duplicate bug to track this has been created (JDK-8039223)
          Show
          tschatzl Thomas Schatzl added a comment - Due to wrong fix version, a duplicate bug to track this has been created ( JDK-8039223 )
          Hide
          vkempik Vladimir Kempik added a comment -
          The fix needed for 8u20 as well
          Show
          vkempik Vladimir Kempik added a comment - The fix needed for 8u20 as well
          Hide
          hgupdate HG Updates added a comment -
          URL: http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/8847586c9037
          User: kevinw
          Date: 2014-04-09 10:43:02 +0000
          Show
          hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot/rev/8847586c9037 User: kevinw Date: 2014-04-09 10:43:02 +0000
          Hide
          hgupdate HG Updates added a comment -
          URL: http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/8847586c9037
          User: amurillo
          Date: 2014-04-14 19:29:06 +0000
          Show
          hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/rev/8847586c9037 User: amurillo Date: 2014-04-14 19:29:06 +0000

            People

            • Assignee:
              vkempik Vladimir Kempik
              Reporter:
              tschatzl Thomas Schatzl
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: