Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8016747

Replace deprecated PlatformLogger isLoggable(int) with isLoggable(Level)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 8
    • Fix Version/s: 8
    • Component/s: core-libs
    • Labels:
    • Resolved In Build:
      b96

      Backports

        Description

        There are 623 occurrences, and hence 623 deprecated build warnings, of PlatformLogger.isLoggable(int) in the jdk source.

        PlatformLogger is an internal API, and used in may places in the jdk. isLoggable(int) has been deprecated in favor of isLoggable(Level). isLoggable(Level) is slightly more efficient, as it avoids the mapping of int to Level.

        The solution is to simply replace isLoggable(int) with isLoggable(Level), providing the appropriate Level. Example:

          - if(logger.isLoggable(PlatformLogger.FINE)) {
          + if(logger.isLoggable(PlatformLogger.Level.FINE)) {

        http://cr.openjdk.java.net/~chegar/platLoggerWarn/webrev/

        I haven't yet filed a bug for this, but I plan to push the changes through TL, rather than splitting the across multiple integration forests.

        Sample warning output:

        tl/jdk/src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java:416: warning: [deprecation] isLoggable(int) in PlatformLogger has been deprecated
        tl/jdk/src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java:422: warning: [deprecation] isLoggable(int) in PlatformLogger has been deprecated
        tl/jdk/src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java:635: warning: [deprecation] isLoggable(int) in PlatformLogger has been deprecated
        ....

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                chegar Chris Hegarty
                Reporter:
                chegar Chris Hegarty
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved: