Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8023762

Add ChronoPeriod interface and bind period to Chronology

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 8
    • Fix Version/s: 8
    • Component/s: core-libs
    • Labels:
    • Subcomponent:
    • Introduced In Version:
      8
    • Resolved In Build:
      b112
    • Verification:
      Verified

      Description

      Currently, Period is defined to be "years, months and days" where the meaning of that only happens when the class is added to a date. This definition is pragmatic, but also pretty icky. It means that a period between two ISO dates can be added to a Hijrah date, an action which isn't meaningful.

      An alternative design would be to create a ChronoPeriod interface with a subset of methods from Period, plus a getChronology() method. Period would implement ChronoPeriod and be the ISO implementation (just like ChronoLocalDate and LocalDate). A private implementation would handle all non-ISO calendar systems, just like ChronoLocalDateImpl.

      With this change, all periods would be chronology specific. Runtime exceptions would prevent a Hijrah-date derived period from being added to an ISO date.

      This requires adding one public interface and one private class to the API, both in the chrono package.

      The change is relatively low risk. It increases runtime safety and is a relatively logical change, since all references to years/months/days should have a related calendar system. However, it does make it harder to transfer periods between two related calendar systems, such as the Japanese, Thai and ISO.

      See Github issue #331; https://github.com/ThreeTen/threeten/issues/331

        Attachments

          Activity

            People

            • Assignee:
              rriggs Roger Riggs
              Reporter:
              rriggs Roger Riggs
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: