Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8024600

[macosx] code prevents use of -Xlint:auxiliaryclass,empty in jdk build

    Details

    • Subcomponent:
    • Resolved In Build:
      b112
    • CPU:
      x86
    • OS:
      os_x

      Description

      Some macosx-specific java code contains conditions flagged by the javac -Xlint:auxiliaryclass,empty flags, preventing those flags from being used in the build of the jdk repo:

      /opt/jprt/T/P1/233622.juh/s/jdk/src/macosx/classes/com/apple/eawt/_AppEventHandler.java:267: warning: auxiliary class _OpenAppHandler in /opt/jprt/T/P1/233622.juh/s/jdk/src/macosx/classes/com/apple/eawt/_AppEventLegacyHandler.java should not be accessed from outside its own source file
          class _OpenAppDispatcher extends _QueuingAppEventDispatcher<com.apple.eawt._OpenAppHandler> {
                                                                                    ^
      /opt/jprt/T/P1/233622.juh/s/jdk/src/macosx/classes/com/apple/eawt/_AppEventHandler.java:268: warning: auxiliary class _OpenAppHandler in /opt/jprt/T/P1/233622.juh/s/jdk/src/macosx/classes/com/apple/eawt/_AppEventLegacyHandler.java should not be accessed from outside its own source file
              void performUsing(com.apple.eawt._OpenAppHandler handler, _NativeEvent event) {
                                              ^
      error: warnings found and -Werror specified
      /opt/jprt/T/P1/233622.juh/s/jdk/src/macosx/classes/com/apple/laf/AquaFileChooserUI.java:1138: warning: auxiliary class AquaComboBoxRendererInternal in /opt/jprt/T/P1/233622.juh/s/jdk/src/macosx/classes/com/apple/laf/AquaComboBoxRenderer.java should not be accessed from outside its own source file
              return new AquaComboBoxRendererInternal(directoryComboBox) {
                         ^
      /opt/jprt/T/P1/233622.juh/s/jdk/src/macosx/classes/com/apple/laf/AquaFileChooserUI.java:1249: warning: auxiliary class AquaComboBoxRendererInternal in /opt/jprt/T/P1/233622.juh/s/jdk/src/macosx/classes/com/apple/laf/AquaComboBoxRenderer.java should not be accessed from outside its own source file
              return new AquaComboBoxRendererInternal(filterComboBox) {
                         ^
      /opt/jprt/T/P1/233622.juh/s/jdk/src/macosx/classes/com/apple/laf/AquaMenuBarUI.java:76: warning: [empty] empty statement after if
                  if (setScreenMenuBar((JFrame)(c.getTopLevelAncestor()))) ;
                                                                           ^

      These warning categories should be cleared in this code so the entire jdk repo can be protected by these javac checks.

      See related build-dev thread:
          http://mail.openjdk.java.net/pipermail/build-dev/2013-August/009795.html
          http://mail.openjdk.java.net/pipermail/build-dev/2013-September/010050.html

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                pchelko Petr Pchelko (Inactive)
                Reporter:
                darcy Joe Darcy
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: