Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8026284

Minimal1 references/support should be removed from BSD/MacOS X

    Details

    • Subcomponent:
    • CPU:
      generic
    • OS:
      generic

      Description

      This issue came up during the code review cycle for JDK-7165611.

      > - hotspot/make/Makefile
      >
      > + $(EXPORT_CLIENT_DIR)/%.dSYM: $(MINIMAL1_BUILD_DIR)/%.dSYM
      >
      > EXPORT_CLIENT_DIR should be EXPORT_MINIMAL_DIR.
      >
      > For fun you can try building minimal on OSX, but I don't know how far you will get:
      >
      > --with-jvm-variants=client,server,minimal1
      >
      > I'll point out obvious issues with minimal VM support anyway.

      Since you pointed out in a later email that minimal1 isn't
      supported on MacOS X, I'm going to drop those changes. I'm
      going to leave the Client VM support since there are folks
      out in OpenJDK trying to get the Client VM working on MacOS X.

      It does look like someone added minimal1 support for other
      non-Linux platforms, but I'm not planning to clean that up.


      > 328 else
      > 329 EXPORT_LIST += $(EXPORT_MINIMAL_DIR)/libjvm.debuginfo
      > 330 endif
      >
      > This pre-existing minimal VM code needs to be modified to reference the dSYM directory on OSX as per the client/server cases.

      Since MacOS X doesn't support the minimal1 config, I've dropped that
      block of logic. Perhaps another bug should be used to remove all
      mention of minimal1 config from the MacOS X/BSD makefiles.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                dcubed Daniel Daugherty
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: