Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8027627

LOG=trace hardcodes value to bash

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 8
    • Fix Version/s: 9
    • Component/s: infrastructure
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b30

      Backports

        Description

        Dmitry Samersoff <dmitry.samersoff@oracle.com> discovered that LOG=trace only works if bash is in /bin. He also suggested the following patch:

        diff -r 22c6f0b7e2b5 common/makefiles/MakeBase.gmk
        --- a/common/makefiles/MakeBase.gmk Tue Oct 15 08:24:31 2013 -0700
        +++ b/common/makefiles/MakeBase.gmk Tue Oct 29 17:15:09 2013 +0400
        @@ -336,7 +336,7 @@
                 # (and causing a crash on Cygwin).
                 # Default shell seems to always be /bin/sh. Must override with bash to get this to work on Solaris.
                 # Only use time if it's GNU time which supports format and output file.
        - WRAPPER_SHELL:=/bin/bash $$(SRC_ROOT)/common/bin/shell-tracer.sh $$(if $$(findstring yes,$$(IS_GNU_TIME)),$$(TIME),-) $$(OUTPUT_ROOT)/build-trace-time.log /bin/bash
        + WRAPPER_SHELL:=$(BASH) $$(SRC_ROOT)/common/bin/shell-tracer.sh $$(if $$(findstring yes,$$(IS_GNU_TIME)),$$(TIME),-) $$(OUTPUT_ROOT)/build-trace-time.log $(BASH)
                 SHELL=$$(warning $$(if $$@,Building $$@,Running shell command) $$(if $$<, (from $$<))$$(if $$?, ($$(wordlist 1, 20, $$?) $$(if $$(wordlist 21, 22, $$?), ... [in total $$(words $$?) files]) newer)))$$(WRAPPER_SHELL)
             endif
             # Never remove warning messages; this is just for completeness

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  ihse Magnus Ihse Bursie
                  Reporter:
                  ihse Magnus Ihse Bursie
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: