Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8027760

JFC schema condition should not have defaults

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 8
    • Fix Version/s: 11
    • Component/s: hotspot
    • Labels:
    • Subcomponent:
      jfr
    • Resolved In Build:
      b15
    • CPU:
      generic
    • OS:
      generic

      Backports

        Description

        If the condtion element for a jfc schema defaults to "true" or "false" for the true and false attrubute, it becomes impossible to create some multiple choice logic For example,

         <condition name="compiler-phase-threshold" true="60 s">
           <test name="compiler-level" operator="equal" value="normal"/>
         </condition>

         <condition name="compiler-phase-threshold" true="10 s">
           <test name="compiler-level" operator="equal" value="detailed"/>
          </condition>

          <condition name="compiler-phase-threshold" true="0 s">
           <test name="compiler-level" operator="equal" value="all"/>
          </condition>
         
        In this case, only when the condition evaluates to true should a modification of compiler-phase-threshold occur. It would be possible to set a default for "true", since it is always possible to negate an expression with <not>, but expressions can be kept simpler if we don't set defaults at all.

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  egahlin Erik Gahlin
                  Reporter:
                  egreijus Erik Greijus (Inactive)
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: