Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8036584

Review comments from 8035897

    XMLWordPrintable

    Details

    • Subcomponent:
    • Resolved In Build:
      b04

      Backports

        Description

        Review comments form 8035897, received after the changes were pushed. See
          http://mail.openjdk.java.net/pipermail/net-dev/2014-March/008303.html

        --- snip --

        This mostly looks okay to me although it's a bit inconsistent for
        NET_Timeout to have a JNIEnv parameter. It might be better to have it
        set errno to ENOMEM or some error and handle it in the call instead.
        Also just on the exception message, I assume it should be "select"
        rather than NET_Select as NET_Select has been removed.

        --- snip ---

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                chegar Chris Hegarty
                Reporter:
                chegar Chris Hegarty
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved: