Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8037283

Flags should remember their cmd line state also if modified by ergonomics

    Details

    • Type: Enhancement
    • Status: Closed
    • Priority: P3
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: 9
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
      gc

      Description

      Today if a flag is set on the command line and later changed by the ergonomics (FLAG_SET_ERGO) the question FLAG_IS_CMDLINE will reply false. This makes the policy code more difficult to write and maintain since we will have to use a separate variable to remember that the flag was set on the command line.
      In some cases we have chosen to update a flag variable without using the proper macro for doing so which will have other consequences (see the related bug about that).

      To clean up the initialization code we should change the flag implementation to store its state in a persistent manner so that we can ask if a flag was set on the command line and if it was set by the ergonomics and get truthful answers in all cases.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                jwilhelm Jesper Wilhelmsson
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: