Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8037806

Enhance get_source.sh to optionally add the subtrees to the top level repo

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P2
    • Resolution: Won't Fix
    • Affects Version/s: 8-pool, 9
    • Fix Version/s: 10
    • Component/s: infrastructure
    • Labels:
      None

      Description

      Enhance get_source.sh to optionally add the subtrees to the top level repo, via "hg tconfig"

      With the old forest extension, you could use any of the fpush, fout, fpull commands right way after using get_source.sh

      But with the new trees extension, you cannot use any trees commands (tpush, tout, tpull, etc) after get_source.sh is run. You need to run "hg tconfig" first.

      This enhancement request is to add a command line option to get_source.sh, such as --trees, to have the script run "hg tconfig" after the repos are cloned. Optionally, you could use "hg showconfig extensions.trees" to see if the user has trees enabled and perform "hg tconfig" automatically, but there may be reasons NOT to configure the repo for trees.

      If you run get_source.sh twice, once for open, and the next for closed repos, you would have to use "hg tconfig --del" before adding them in the second running of get_source.sh.

        Activity

        Hide
        ihse Magnus Ihse Bursie added a comment -
        Since get_source knows what repos it clones, we should be able to provide that information to the tree configuration without having to scan the directory structure. Not sure if the trees extensions supports that (but otherwise we should fix it to do that).
        Show
        ihse Magnus Ihse Bursie added a comment - Since get_source knows what repos it clones, we should be able to provide that information to the tree configuration without having to scan the directory structure. Not sure if the trees extensions supports that (but otherwise we should fix it to do that).
        Hide
        erikj Erik Joelsson added a comment -
        The configuration is pretty simple. The root dir of each sub repo is listed relative to the root repo in .hg/trees.
        Show
        erikj Erik Joelsson added a comment - The configuration is pretty simple. The root dir of each sub repo is listed relative to the root repo in .hg/trees.
        Hide
        ihse Magnus Ihse Bursie added a comment -
        We should not directly modify the tree implementation files. However, there is a suitable command, "hg tconfig --add langtools hotspot jdk ..." will achieve what we want.
        Show
        ihse Magnus Ihse Bursie added a comment - We should not directly modify the tree implementation files. However, there is a suitable command, "hg tconfig --add langtools hotspot jdk ..." will achieve what we want.
        Hide
        ihse Magnus Ihse Bursie added a comment -
        In jdk10, we will move away from the forest repo structure, so this bug makes no sense to fix anymore.
        Show
        ihse Magnus Ihse Bursie added a comment - In jdk10, we will move away from the forest repo structure, so this bug makes no sense to fix anymore.

          People

          • Assignee:
            Unassigned
            Reporter:
            katleman David Katleman
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: