Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8037823

G1: Add time for "Weak Root Fixup" and "JNI Handle Fixup" in GC log

    Details

    • Type: Enhancement
    • Status: Closed
    • Priority: P4
    • Resolution: Not an Issue
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: hotspot
    • Subcomponent:
      gc

      Description

      The time for adjusting weak JNI handles is currently included in the "Other" time. With the addition of "String Dedup Fixup" it might be worth considering also splitting out the "JNI Handle Fixup" time into a separate item, and add a "Weak Root Fixup" as the umbrella item for both dedup and JNI. It would then look something like this:

         [....]
         [Code Root Fixup: 0.0 ms]
         [Code Root Migration: 0.0 ms]
         [Code Root Purge: 0.0 ms]
         [Weak Root Fixup: 0.6 ms]
           [JNI Handles Fixup: 0.1 ms]
           [String Dedup Fixup: 0.5 ms, GC Workers: 13]
              [Queue Fixup (ms): Min: 0.0, Avg: 0.0, Max: 0.1, Diff: 0.1, Sum: 0.1]
              [Table Fixup (ms): Min: 0.0, Avg: 0.0, Max: 0.3, Diff: 0.3, Sum: 0.3]
         [Clear CT: 0.2 ms]
         [Other: 0.7 ms]
         [....]

      Where "Weak Root Fixup" and "JNI Handles Fixup" are new items (split out from "Other") and "String Dedup Fixup" moved in under "Weak Root Fixup".

      (The suggestion to do this surfaced during the code review of string deduplcation)

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              pliden Per Liden
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: