Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8048124

Read hijrah-config-umalqura.properties as a resource

    Details

    • Subcomponent:
    • Resolved In Build:
      b38
    • CPU:
      generic
    • OS:
      generic

      Backports

        Description

        This bug asks to examine hijra-config-umalqura.properties files under ${java.home}/lib and understand if it is a configuration and whether it should be a resources file (in resources.jar).

        The motive for this bug is the modular JDK where we need the flexibility to put anything that is module-private into a module-private location. In this case it would appear that the above files are not a supported interface and so should move to a location that should be read as resources.

          Issue Links

            Activity

            Hide
            alanb Alan Bateman added a comment -
            Any update on this? We need to establish if is supported to edit hijra-config-umalqura.properties or not. This is so that we have a definite list of user-editable configuration files to move to the conf directory.
            Show
            alanb Alan Bateman added a comment - Any update on this? We need to establish if is supported to edit hijra-config-umalqura.properties or not. This is so that we have a definite list of user-editable configuration files to move to the conf directory.
            Hide
            rriggs Roger Riggs added a comment -
            It seems unlikely that we need to add new Islamic calendars between updates.
            So I think the function of the calendar.properties file can be removed.

            The individual Islamic calendars can be hard coded in HijrahCalendar.
            Each calendar does have a data file which will be treated as a resource.
            Initially, there is only one.
            Show
            rriggs Roger Riggs added a comment - It seems unlikely that we need to add new Islamic calendars between updates. So I think the function of the calendar.properties file can be removed. The individual Islamic calendars can be hard coded in HijrahCalendar. Each calendar does have a data file which will be treated as a resource. Initially, there is only one.
            Hide
            chegar Chris Hegarty added a comment -
            There are currently two source files in the jdk repository that are incorrectly located in the 'conf' directory.
              jdk/src/java.base/share/conf/calendars.properties
              jdk/src/java.base/share/conf/hijrah-config-umalqura.properties

            The only files that should be in the source conf directory are files that are intended to be user editable, these are not, and therefore should be moved. As part of this work these files should be moved to a suitable location in the source tree that matches there intended location in the built artifact.

            Show
            chegar Chris Hegarty added a comment - There are currently two source files in the jdk repository that are incorrectly located in the 'conf' directory.   jdk/src/java.base/share/conf/calendars.properties   jdk/src/java.base/share/conf/hijrah-config-umalqura.properties The only files that should be in the source conf directory are files that are intended to be user editable, these are not, and therefore should be moved. As part of this work these files should be moved to a suitable location in the source tree that matches there intended location in the built artifact.
            Hide
            alanb Alan Bateman added a comment -
            If the plan is to eliminate or move these to resource files then I think we can drop the "bertha" label from this issue. To Chris' point then if we are retaining the properties files as source files but not user-editable configuration files then they will need a new home in the src tree.
            Show
            alanb Alan Bateman added a comment - If the plan is to eliminate or move these to resource files then I think we can drop the "bertha" label from this issue. To Chris' point then if we are retaining the properties files as source files but not user-editable configuration files then they will need a new home in the src tree.
            Hide
            alanb Alan Bateman added a comment -
            This has been reviewed on the core-libs-dev and will go into jdk9/dev in due course. There aren't any changes required specifically for the modular image so I will drop the bertha label from this issue.
            Show
            alanb Alan Bateman added a comment - This has been reviewed on the core-libs-dev and will go into jdk9/dev in due course. There aren't any changes required specifically for the modular image so I will drop the bertha label from this issue.
            Hide
            hgupdate HG Updates added a comment -
            URL: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/529f33e7f04d
            User: rriggs
            Date: 2014-10-28 22:07:03 +0000
            Show
            hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/529f33e7f04d User: rriggs Date: 2014-10-28 22:07:03 +0000
            Hide
            hgupdate HG Updates added a comment -
            URL: http://hg.openjdk.java.net/jdk9/dev/rev/ce3b04a39f79
            User: rriggs
            Date: 2014-10-28 22:07:33 +0000
            Show
            hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk9/dev/rev/ce3b04a39f79 User: rriggs Date: 2014-10-28 22:07:33 +0000
            Hide
            hgupdate HG Updates added a comment -
            URL: http://hg.openjdk.java.net/jdk9/jdk9/rev/ce3b04a39f79
            User: lana
            Date: 2014-11-05 19:35:05 +0000
            Show
            hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk9/jdk9/rev/ce3b04a39f79 User: lana Date: 2014-11-05 19:35:05 +0000
            Hide
            hgupdate HG Updates added a comment -
            URL: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/529f33e7f04d
            User: lana
            Date: 2014-11-05 19:35:24 +0000
            Show
            hgupdate HG Updates added a comment - URL: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/529f33e7f04d User: lana Date: 2014-11-05 19:35:24 +0000

              People

              • Assignee:
                rriggs Roger Riggs
                Reporter:
                naoto Naoto Sato
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Due:
                  Created:
                  Updated:
                  Resolved: