Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8051680

(ref) unnecessary process_soft_ref_reconsider

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 18
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
      gc
    • Resolved In Build:
      b06
    • CPU:
      generic
    • OS:
      generic

      Description

      I think ReferenceProcessor::process_soft_ref_reconsider (formerly known as process_phase1) is unnecessary. It seems like it shouldn't find anything, because of the similar policy-based test in ReferenceProcessor::discover_reference. And if it does find anything, the liveness analysis from the referent is executed with discovery disabled, which I think is wrong for what is being done by this phase. I think we do need to be performing discovery on references found by chasing through the referents of soft references that we choose by policy to keep alive.

      So I think this phase is presently an expensive nop, and should be deleted entirely, along with supporting infrastructure such as DiscoveredListIterator::make_active(), which I think is only used here.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              ayang Albert Yang
              Reporter:
              kbarrett Kim Barrett
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: