Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8064947

Clean up BarrierSet ctor/dtor

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: hotspot
    • Subcomponent:
      gc
    • Resolved In Build:
      b51
    • CPU:
      generic
    • OS:
      generic

      Backports

        Description

        BarrierSet is an abstract base class. There is no need for its ctor to be public (it can be protected instead). Its destructor should either be protected or public and virtual, with the former preferred if public not required by usage, which it better not be, given that it's presently non-virtual.

        The ctor should also take an argument specifying the kind, rather than initializing _kind to Uninit and requiring derived classes to reassign _kind in their constructors.

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  jprovino Joseph Provino (Inactive)
                  Reporter:
                  kbarrett Kim Barrett
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: