Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8065576

Enable pipefail in the shell used by make to better detect build errors

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: infrastructure
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b49

      Backports

        Description

        In JDK-8065138 it was discovered that non zero return values of sed was ignored if the result of sed was piped to another process, which in turn had a zero return value. Having the build fail in this case would have been preferred. A way to achieve this would be to change the SHELL used by make to bash and enable the option pipefail. We should experiment with this and see if it can be done.

        Note that we already require bash to build so it is already present on all build platforms, and it is used to run the log wrapper script.

        It's quite possible that this will uncover other build failures that would then need to be fixed or handled appropriately.

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  erikj Erik Joelsson
                  Reporter:
                  erikj Erik Joelsson
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: