Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8066624

CHECK_(nullHandle) is unnecessary

    XMLWordPrintable

    Details

      Description


      There was a long ago experiment to remove the default constructors for Handle to force passing THREAD argument where one was available, so that there weren't unnecessary calls to Thread::current().
      Thread::current() showed up as #1 on a flat profile once. This is no longer true, and less true now that most of the metadata handles have been removed.

      If you pass NULL to Handle() it doesn't call Thread::current() anyway or generate code to do so, so the CHECK_(nullHandle) mess can go away in favor of CHECK_NULL.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              coleenp Coleen Phillimore
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: