Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8072911

Remove includes of oop.inline.hpp from .hpp files

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P2
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
      gc
    • Resolved In Build:
      b53

      Backports

        Description

        Our inline.hpp files should preferably only be included from .cpp files or other .inline.hpp files. When they are included in .hpp files, the include dependency of the implementation spreads to unrelated parts of the code base, and it's easy to get circular dependencies.

        This guide line is documented on:
        https://wiki.openjdk.java.net/display/HotSpot/StyleGuide#Files

        oop.inline.hpp is one of the more problematic files, and I propose a patch to get rid of all inclusions of oop.inline.hpp from other .hpp files.

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  stefank Stefan Karlsson
                  Reporter:
                  stefank Stefan Karlsson
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: