Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8072956

BarrierSet Flags enum is unused

    XMLWordPrintable

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 10
    • Component/s: hotspot
    • Subcomponent:
      gc
    • CPU:
      generic
    • OS:
      generic

      Description

      The BarrierSet class has an embedded enum named Flags. That type and the associated enum tags are unused.

      The Flags enum was added as part of the fix for
      6627983: G1: Bad oop deference during marking

      However, there were no uses of the Flags enum type or either of its tags in that changeset. Instead, there are a number of functions which were given new "bool dest_uninitialized" parameters. Perhaps the intent was that the new parameter should have Flags as its type and use the enum tags as arguments, for better type safety and self-documentation of the code. If so, that didn't happen.

      We should either change the code to use the Flags enum or eliminate it.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              kbarrett Kim Barrett
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: