Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8074795

Fix for JDK-8030115 breaks Windows build in 8u

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: P1
    • Resolution: Duplicate
    • Affects Version/s: 8u60
    • Fix Version/s: None
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
      svc
    • Introduced In Version:

      Description

      The fix for 8030115 breaks the build on windows:


      c:/jprt/T/P1/021115.drlong/s/jdk/src/share/native/sun/tracing/dtrace/JVM.c(200) : error C2143: syntax error : missing ';' before 'type'
      c:/jprt/T/P1/021115.drlong/s/jdk/src/share/native/sun/tracing/dtrace/JVM.c(201) : error C2065: 'count' : undeclared identifier
      c:/jprt/T/P1/021115.drlong/s/jdk/src/share/native/sun/tracing/dtrace/JVM.c(201) : error C2065: 'count' : undeclared identifier
      c:/jprt/T/P1/021115.drlong/s/jdk/src/share/native/sun/tracing/dtrace/JVM.c(202) : error C2065: 'count' : undeclared identifier
      c:/jprt/T/P1/021115.drlong/s/jdk/src/share/native/sun/tracing/dtrace/JVM.c(204) : error C2065: 'count' : undeclared identifier
      c:/jprt/T/P1/021115.drlong/s/jdk/src/share/native/sun/tracing/dtrace/JVM.c(212) : error C2065: 'count' : undeclared identifier
      make[2]: *** [/cygdrive/c/jprt/T/P1/021115.drlong/s/build/windows-x86_64-normal-server-fastdebug/jdk/objs/libjsdt/JVM.obj] Error 2

      The older MSC compiler doesn't support declarations in the middle of blocks IIRC so barfs on this:

      @@ -195,16 +197,24 @@
           jvm_providers = (JVM_DTraceProvider*)calloc(
               num_providers, sizeof(*jvm_providers));

      - for (i = 0; i < num_providers; ++i) {
      - JVM_DTraceProvider* p = &(jvm_providers[i]);
      + int count = 0;
      + for (; count < num_providers; ++count) {

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                dholmes David Holmes
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: