Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8074838

Resolve disabled warnings for libj2pkcs11

    Details

      Description

      With JDK-8074096 (changeset http://hg.openjdk.java.net/jdk9/dev/jdk/rev/676ec3e5cfc3), most warnings in the JDK native libraries were disabled to minimize the noise when building.

      One of the library that had warnings disabled are libj2pkcs11, in make/lib/Lib-jdk.crypto.pkcs11.gmk.
      The following warnings are disabled for this library:
      DISABLED_WARNINGS_solstudio := E_DECLARATION_IN_CODE
      DISABLED_WARNINGS_microsoft := 4013 4267

      (Note that warnings are disabled per toolchain type (essentially, compiler). Also note that disabling warnings does not work for gcc prior to version 4.4.)

      Blindly hiding warnings is just sweeping the problems under the rug. On the other hand, not all warnings are meaningful to fix in the source code.

      The expected outcome of this bug is, for each disabled warning category, either:
      1) The code is fixed so the warning can be re-enabled (by removing it from the list of disabled warnings for that library), or
      2) The warning is kept disabled, but in that case a rationale added to the stanza for that library in the makefile.

      Incremental builds is helpful when testing the effect of warnings. Once the build has fully finished, if the list of warnings is modified for this library,
      only that library is rebuilt on future calls to make (without clean). This makes it easy to spot the effect of re-enabling warnings for a single library.

      For reference, the log files prior and after JDK-8074096 was pushed is stored here:
      http://cr.openjdk.java.net/~ihse/no-warnings/saved-logs-for-JDK-8074096/

        Attachments

          Activity

            People

            • Assignee:
              ascarpino Anthony Scarpino
              Reporter:
              ihse Magnus Ihse Bursie
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: