Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8076646

nashorn tests should avoid using package names used by nashorn sources

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: core-libs
    • Labels:
    • Subcomponent:
    • Resolved In Build:
      b59
    • CPU:
      generic
    • OS:
      generic

      Backports

        Description

        Many test package names are same as nashorn source package names (eg. jdk.nashorn.api.scripting, jdk.nashorn.internal.runtime). It is better to avoid this:

        1) We don't have any package-private access from tests to nashorn internal, package-private classes

        2) Even though same package name is used, nashorn is loaded by boot loader or extension loader (depending on jdk version) and tests are loaded by launcher loader and so these are different runtime packages anyway. Any confusion within IDE ("same package " as seen in IDE) can be avoided by different package names.

        3) In a modular (jigsaw) world, we need to avoid this package name collision b/w source and test classes.

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                sundar Sundararajan Athijegannathan
                Reporter:
                sundar Sundararajan Athijegannathan
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved: