Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8078021

SATB apply_closure_to_completed_buffer should have closure argument

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P4
    • Resolution: Fixed
    • Affects Version/s: 9
    • Fix Version/s: 9
    • Component/s: hotspot
    • Labels:
      None
    • Subcomponent:
      gc
    • Resolved In Build:
      b64
    • CPU:
      generic
    • OS:
      generic

      Backports

        Description

        SATBMarkQueueSet::apply_closure_to_completed_buffer() presently takes a worker_id index. It uses that to look up the closure associated with the worker by a preceding call to set_closure.

        There is only one caller of this apply function, CMTask::drain_satb_buffers. It creates the desired closure, associates the closure with its worker id, and then calls apply_closure_to_completed_buffer.

        We could eliminate set_closure and the underlying data structure, by simply having the apply_closure_xxx function take the closure as an argument rather than the worker id.

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  kbarrett Kim Barrett
                  Reporter:
                  kbarrett Kim Barrett
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: