Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8093011

[Dialogs] Write unit tests

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 8u40
    • Fix Version/s: 8u40
    • Component/s: javafx
    • Labels:
      None

      Description

      There are a number of corner cases that need to be unit tests in the dialogs API. Here's a list of some areas that need testing (over and above the simple unit tests all API should get):

      1) Tests to ensure that a forcibly closed dialog is handled correctly:
      a) One, non-cancel button (dialog should close)
      b) Multiple buttons, all non-cancel (dialog should not close)
      c) Multiple buttons, with one cancel button (dialog should close)
      d) Multiple buttons, with multiple cancel buttons (dialog should close, the first cancel button should be used)

      2) Tests to ensure that a closed dialog returns the correct value, depending on its R type, including:
      a) Test to see what result and showAndWait() return when R is Void
      b) Test to see what result and showAndWait() return when R is ButtonType
      c) Test to see what result and showAndWait() return when R is String, and no resultConverter has been specified (expect a class cast exception in the unit test)
      d) Test to see what result and showAndWait() return when R is String, when a resultConverter has been specified that returns null (expect Optional.empty())
      e) Test to see what result and showAndWait() return when R is String, when a resultConverter has been specified that returns a valid String

      3) Test all cases above to ensure that non-blocking and blocking dialogs have the same result values given the same user input.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jgiles Jonathan Giles
              Reporter:
              jgiles Jonathan Giles
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Imported: