Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8098111

Reduce frequency of Cells updating items

    XMLWordPrintable

    Details

      Description

      Based on feedback from Rich: "The issue I have is that the updateItem is getting called excessively. It appears that if the list item count changes, then ListViewSkin forces all the cells to be recreated. So in those cases, we don't need the cells to update themselves". He goes on to say "I had a bug in the app which it turns out is fixed by these changes (I'm not 100% sure why, other than cells were still existing but not being relaid out all the time, or some such). Now that we're no longer creating cells ad infinitum, it looks better. Plus, I'm only creating 8 cells tops now instead of a few hundred, depending on the length of time the app ran :)".

      See the attached patch for Rich's suggested fix, but review it first before applying to the repo. Also, if the patch is a good one, consider applying to list, tree and table code consistently.

        Attachments

        1. diff.diff
          2 kB
        2. flow.diff
          9 kB

          Issue Links

            Activity

              People

              Assignee:
              jgiles Jonathan Giles
              Reporter:
              jgiles Jonathan Giles
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Due:
                Created:
                Updated:
                Resolved:
                Imported: