Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8102169

Node Orientation - API issue: Should effective orientation be a property?

    Details

      Description

      >>
      >>>
      >>> > Shouldn't effectiveNodeOrientation be a property?
      >>>
      >>> That's a possibility. It would be a properly that changed when inherited orientation up the ancestor tree changed. Do we have any other properties like this in FX?
      >>
      >> localToSceneTransform But I admit there is some extra logic needed for such properties that we don't want to add blindly for performance reasons. So it may be better to just rename the getter to simply effectiveNodeOrientation().
      >>
      >
      > It might be that this needs to be a property after all. The issue is that a child may have state that is sets based on effective orientation (say alignment of a text node) and this state needs to be kept up to date with effective orientation. However, providing the method is defined correctly, there is nothing stopping it from becoming a property in future. I understand the performance issue. I will investigate further.

      For a property we'd have effectiveNodeOrientationProperty() and getEffectiveNodeOrientation(). For a non-property we'd have something like effectiveNodeOrientation(). So I think we need to decide in the beginning..

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                lnerad Ľubomír Nerád
                Reporter:
                snorthov Steve Northover (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Imported: