Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8103575

Improve occlusion culling to include effects

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: P3
    • Resolution: Fixed
    • Affects Version/s: 8
    • Fix Version/s: 8
    • Component/s: javafx
    • Labels:

      Description

      With the fix for RT-32286, I disabled the contribution of effects to the opaque region because it was faulty in cases where the result of reducesOpaquePixels would change over time (for example, by changing the Mode of a Blend effect). This tweak improves the situation slightly, in two ways:
          1) If you set an effect, we will still look for dirty regions, but we will consult with the effect every time the getOpaqueRegion method is called (essentially disabling the caching of opaque regions).
          2) We will do #1 unless an Effect tells us that it does not reducesOpaquePixels and NEVER WILL CHANGE.

      An additional fix should be made later where we will also have opaqueInsets or an opaqueRegion on the Effect such that an effect that does reducesOpaquePixels may still be able to contribute to the opaque region if it so happens that it only messes with pixels outside some fixed area. For example a BoxBlur might be able to say that it doesn't mess with opacity of bits with insets of 3 from the edges (if it has a certain value for iterations etc).

        Attachments

          Activity

            People

            • Assignee:
              rbair Richard Bair
              Reporter:
              rbair Richard Bair
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Imported: