Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8110063

Change for MOBL-1468 caused unit test failure: ContainerTest

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P1
    • Resolution: Fixed
    • Affects Version/s: fx1.3.1
    • Fix Version/s: fx1.3.1
    • Component/s: javafx
    • Labels:
      None

      Description

      The fix for MOBL-1468 has caused the following failure:

          [junit] Testsuite: javafx.scene.layout.ContainerTest
          [junit] Tests run: 9, Failures: 1, Errors: 0, Time elapsed: 0.349 sec
          [junit]
          [junit] Testcase: testSnapToPixelTrue(javafx.scene.layout.ContainerTest): FAILED
          [junit] expected:<99.0> but was:<100.0>
          [junit] junit.framework.AssertionFailedError: expected:<99.0> but was:<100.0>
          [junit] at javafx.fxunit.FXTestCase.assertEquals(FXTestCase.fx:61)
          [junit] at javafx.fxunit.FXTestCase.assertEquals(FXTestCase.fx:55)
          [junit] at javafx.scene.layout.ContainerTest.testSnapToPixelTrue(ContainerTest.fx:117)
          [junit]
          [junit]
          [junit] Test javafx.scene.layout.ContainerTest FAILED

      Here is the changeset in question:

      details: http://jfxsrc.sfbay.sun.com/javafx/1.3.1/MASTER/runtime/rev/25ff6fc0020c
      changeset: 6268:25ff6fc0020c
      user: Jan Sterba <Jan.Sterba@sun.com>
      date: Tue Jun 08 09:17:12 2010 +0200
      description:
      MOBL-1468: snap to pixel should cause decimal position rounding not stripping


      Please note that no changesets should be integrated to MASTER without first running "ant test" from the top level.


      We can easily fix this by changing the test to expect rounding rather than truncation, as long as we all agree that this behavioral change is the correct and desired change.

        Attachments

          Activity

            People

            • Assignee:
              kcr Kevin Rushforth
              Reporter:
              kcr Kevin Rushforth
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Imported: