Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8115693

When the user-agent stylesheet is added, the StyleHelper cache needs to be cleared so that new styles can be calculated

    Details

      Description

      From David:
      When the user-agent stylesheet is added, the StyleHelper cache needs to be cleared so that new styles can be calculated. This means that any existing StyleHelper is no longer valid and nodes need to reapply CSS. This becomes problematic, however, since the code is in the middle of reapplying CSS when this call happens. The fix here is to change StyleHelper in Node to be a Reference. Thus, if the StyleHelper is cache cleared on by the StyleManager, the Node will know to recreate its StyleHelper since the referent will be null.

      The patch is attached. This patch still needs further testing. One thing in particular is to see if this causes the StyleHelper's calculated value cache to leak.

        Attachments

        1. RT-15744
          12 kB
        2. RT-15744
          10 kB

          Activity

            People

            • Assignee:
              dgrieve David Grieve (Inactive)
              Reporter:
              kwwong Kinsley Wong
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Imported: