Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8116555

Node Orientation - API issue: Should isAutomaticallyMirrored() be protected?

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: P2
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: javafx
    • Labels:

      Description

      > I am not a fan of protected. Other than indicating explicitly that subclasses are supposed to override this method, are there any other benefits?

      I believe it is a good approach not to publish things that don't need to be public. It is a node implementation thing, it should not confuse users in the list of publicly accessible methods. Other than you not being a fan, are there any concrete reasons for it to be public? (the fan thing doesn't leave much room for discussion)

      <rant>
      Steve says: "Protected is a waste of time. There is only API in the world. API is something people see. Non-API is your implementation. Every time I have defined a method to be protected in the past, I have always later wanted it to be public. The advantage of protected is that it indicates that you should override it but we have @Override for that now."
      </rant>

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              leifs Leif Samuelsson (Inactive)
              Reporter:
              snorthov Steve Northover (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Imported: